Document persistent-file MCP OAuth storage in Rust - #2328
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Documents Rust support for the persistent-file MCP OAuth storage mode while preserving the existing string-based API.
Changes:
- Documents behavior for create and resume configurations/builders.
- Tests unchanged wire serialization for both request paths.
Show a summary per file
| File | Description |
|---|---|
rust/src/types.rs |
Adds API documentation and serialization coverage. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
|
Thanks for documenting the new Since this is a runtime-wide capability, could you extend the same support/documentation to the other SDKs (Node, C#, Python, Go, and Java) so all 6 stay consistent? Specifically:
For test coverage, please stick to focused unit-level serialization/wiring tests per language (like the one you added for Rust) rather than new E2E tests — that keeps this change proportional to its scope. Documenting/enabling this only in Rust leaves an avoidable capability and documentation gap for users of the other 5 SDKs. Once the above is in, please mark this ready for review again. Thanks! |
Why
The Copilot agent runtime is adding a
persistent-fileMCP OAuth token storage mode. Rust SDK consumers need to be able to select and understand this mode when creating or resuming sessions, including github/github-app#11730.What changed
persistent-fileon Rust create and resume session configuration APIs and builders.Option<String>API shape so the change remains source compatible and matches the existing wire contract.Testing
cd rust && cargo +nightly-2026-04-14 fmt --checkcd rust && cargo clippy --all-features --lib --tests -- -D warningscd rust && cargo test --all-features session_configs_serialize_persistent_file_oauth_storage